Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add erc1155 listener/handler #254

Merged
merged 16 commits into from
Mar 21, 2024
Merged

feat: add erc1155 listener/handler #254

merged 16 commits into from
Mar 21, 2024

Conversation

tcar121293
Copy link
Contributor

add erc1155 listener/handler

Description

Added erc1155 deposit listener and message handler
added unit tests for deposit listener and message handler

Related Issue Or Context

Closes: #253

How Has This Been Tested? Testing details.

Unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

mpetrun5
mpetrun5 reviewed Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@mpetrun5 mpetrun5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! E2E tests to confirm

chains/evm/listener/deposit-handler_test.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 65.0 %\ ✨ ✨ ✨

@tcar121293
update go.mod;
6ac302d 
Signed-off-by: tcar <[email protected]>
@tcar121293
go mod tidy;
864372b 
Signed-off-by: tcar <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 65.0 %\ ✨ ✨ ✨

@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 65.0 %\ ✨ ✨ ✨

@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 65.0 %\ ✨ ✨ ✨

@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 65.1 %\ ✨ ✨ ✨

@tcar121293 tcar121293 marked this pull request as ready for review March 14, 2024 11:16
@tcar121293 tcar121293 requested a review from freddyli7 as a code owner March 14, 2024 11:16
@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 65.1 %\ ✨ ✨ ✨

@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 65.1 %\ ✨ ✨ ✨

@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 65.1 %\ ✨ ✨ ✨

@tcar121293
increese gas;
a0f8052 
Signed-off-by: tcar <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 65.1 %\ ✨ ✨ ✨

mpetrun5
mpetrun5 reviewed Mar 20, 2024
View reviewed changes
e2e/evm/evm_test.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 65.1 %\ ✨ ✨ ✨

@tcar121293 tcar121293 requested a review from mpetrun5 March 21, 2024 12:00
@tcar121293 tcar121293 merged commit 68923e3 into main Mar 21, 2024
8 checks passed
@tcar121293 tcar121293 deleted the tcar/add-erc1155-handler branch March 21, 2024 12:09
@MakMuftic MakMuftic mentioned this pull request Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmlinaric nmlinaric nmlinaric approved these changes

@mpetrun5 mpetrun5 mpetrun5 approved these changes

@MakMuftic MakMuftic Awaiting requested review from MakMuftic MakMuftic is a code owner

@freddyli7 freddyli7 Awaiting requested review from freddyli7 freddyli7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement ERC1155 listener/handler
3 participants
@tcar121293 @mpetrun5 @nmlinaric