Upgrade to JUnit 4 #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `extends TestCase` from test classes. Add `@Test` to all test methods and `@Before` to `setUp()` methods.
Remove `extends TestCase` from test classes. Add `@Test` to all test methods, `@Before` to `setUp()` methods and `@After` to `tearDown()` methods. Class `JsfUtilsTests` still indirectly inherits from `TestCase` via `org.apache.myfaces.test.base.AbstractJsfTestCase`.
Remove `extends TestCase` from test classes. Add `@Test` to all test methods, `@Before` to `setUp()` methods and `@After` to `tearDown()` methods. Remove a couple unused imports in test classes.
Remove `AbstractFlowExecutionTests`'s dependency on `junit.framework.TestCase`. Also remove its constructors which are now useless. Also remove constructors taking a `String name` argument from `AbstractExternalizedFlowExecutionTests` and `AbstractXmlFlowExecutionTests` as that parameter is not used in any of the three classes.
|
I've already signed Pivotal's CLA, by the way. |
|
Also filed as SWF-1738 on jira.spring.io. |
|
@edysli, thanks for the contribution! I think internal tests should go directly to JUnit 5 while for the flow test support we should provide an option to upgrade to either JUnit 5 or 4 but not require it. That way we could get the changes into a maintenance release without waiting for another minor or major release. I've also split this into two parts, SWF-1739 and SWF-1740 with some initial thoughts. If you'd like to rework the PR accordingly that would be much appreciated! |
|
Hey @rstoyanchev, thanks for sharing your thoughts! :) That makes sense, I'll split this PR in two then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JUnit version 5 has been out for a while so it's time to upgrade from version 3 to 4, right? ;)
My end goal with this is to remove
AbstractFlowExecutionTests's inheritance on JUnit 3'sTestCasewhich causes all sorts of weirdness in my tests using Spring Webflow with JUnit 4 (need to use@RunWith(JUnit4.class)). This prevents my flow tests from using JUnit 5.