Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Jackson serialization support for LDAP classes #9263

Closed
wants to merge 9 commits into from
Closed

Provide Jackson serialization support for LDAP classes #9263

wants to merge 9 commits into from

Conversation

markusheiden
Copy link
Contributor

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 4, 2020
@markusheiden markusheiden mentioned this pull request Dec 4, 2020
Closed
@eleftherias eleftherias self-assigned this Dec 7, 2020
@eleftherias eleftherias added in: ldap An issue in spring-security-ldap type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 7, 2020
@eleftherias eleftherias mentioned this pull request Aug 9, 2021
Closed
@pengliaoye
Copy link

which time to merge this pull request

eleftherias
eleftherias suggested changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @markusheiden!
Please include some tests for these changes. You can see similar tests in OAuth2AuthorizedClientMixinTests.

@pengliaoye
Copy link

any progress?

@markusheiden
Copy link
Contributor Author

I'm a bit low on time currently, but I will provide the tests.

@eleftherias
Copy link
Contributor

Hey @markusheiden, would you like to continue working on this PR or would you prefer if someone from the team picked up from where you left off?

@eleftherias eleftherias added the status: waiting-for-feedback We need additional information before we can continue label Nov 19, 2021
@markusheiden
Copy link
Contributor Author

Yes. Sorry for not being able to provide the tests in a timely manner...

Status quo: The tests I added are mostly empty shells or copy and paste from existing tests.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Nov 21, 2021
@eleftherias eleftherias changed the title Provide missing LDAP JSON support for Spring Session Provide Jackson serialization support for LDAP classes Nov 26, 2021
@eleftherias eleftherias removed the status: feedback-provided Feedback has been provided label Nov 29, 2021
@eleftherias eleftherias added this to the 6.0.0-M1 milestone Nov 29, 2021
eleftherias pushed a commit that referenced this pull request Nov 29, 2021
@markusheiden @eleftherias
Start with LDAP Jackson2 mixins
7cfd415 
Issue gh-9263
@eleftherias
Copy link
Contributor

Thanks for the PR @markusheiden! I merged the commits into 7cfd415 and added tests via a polish commit 4f8c1b3.
I'm also going to backport these changes to the 5.7.x branch, so they will be available in 5.7.0-M1 as well.

eleftherias pushed a commit that referenced this pull request Nov 29, 2021
@markusheiden @eleftherias
Start with LDAP Jackson2 mixins
3c18278 
Issue gh-9263
eleftherias added a commit that referenced this pull request Nov 29, 2021
@eleftherias
Polish LDAP serialization
bbeca7c 
Closes gh-9263
@eleftherias eleftherias modified the milestones: 6.0.0-M1, 5.7.0-M1 Dec 7, 2021
@Jxiu Jxiu mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleftherias eleftherias eleftherias requested changes

Assignees

@eleftherias eleftherias

Labels
in: ldap An issue in spring-security-ldap type: enhancement A general enhancement
Projects
None yet
Milestone
5.7.0-M1
Development

Successfully merging this pull request may close these issues.
4 participants
@markusheiden @pengliaoye @eleftherias @spring-projects-issues