-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Add JwtClaimValidator #7962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JwtClaimValidator #7962
Conversation
|
Hi @jzheaux feedback on code & implementation improvements is highly appreciated. |
jzheaux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @zeeshanadnan! I've left some feedback inline.
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/JwtClaimValidator.java
Outdated
Show resolved
Hide resolved
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/JwtClaimValidator.java
Outdated
Show resolved
Hide resolved
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/JwtClaimValidator.java
Outdated
Show resolved
Hide resolved
...auth2-jose/src/test/java/org/springframework/security/oauth2/jwt/JwtClaimValidatorTests.java
Outdated
Show resolved
Hide resolved
...auth2-jose/src/test/java/org/springframework/security/oauth2/jwt/JwtClaimValidatorTests.java
Outdated
Show resolved
Hide resolved
d5ff515 to
fab1428
Compare
|
Hi @jzheaux updated the PR with the requested changes. For any further changes let me know. |
|
@zeeshanadnan thanks for the edits! Since As part of this PR, would you please change public JwtIssuerValidator(String issuer) {
this.validator = new JwtClaimValidator(ISS, iss -> issuer.equals(iss));
}This will help reinforce the contract being proposed. |
fab1428 to
2ad1bc2
Compare
|
Hi @jzheaux, updated the PR with requested changes. |
2ad1bc2 to
02d03ed
Compare
|
Thanks, @zeeshanadnan! This is now merged into Also, I updated some related tests in 283e451 |
|
@jzheaux thanks for the merge & guidance. Sorry for lot of iterations & any inconvenience. |
|
My pleasure, @zeeshanadnan. I think I caused some of that churn, too. :) I hope to see more contributions from you! Thanks, again, for taking the initiative. |
fixes gh-7860