Skip to content

Conversation

@tatisled
Copy link
Contributor

@tatisled tatisled commented Mar 12, 2023

Fixes gh-12825

@pivotal-cla
Copy link

@tatisled Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@tatisled Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 12, 2023
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tatisled, for the PR! I've left some feedback inline.

@jzheaux jzheaux self-assigned this Mar 20, 2023
@jzheaux jzheaux added status: duplicate A duplicate of another issue type: bug A general bug in: saml2 An issue in SAML2 modules and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 20, 2023
@tatisled tatisled force-pushed the tatisled/add-nameIdFormat-to-saml-auth-request branch from 0e4a899 to 8f1104a Compare March 21, 2023 20:01
@tatisled tatisled force-pushed the tatisled/add-nameIdFormat-to-saml-auth-request branch from 8f1104a to c7ea40a Compare March 21, 2023 20:04
@tatisled
Copy link
Contributor Author

Thank you, @jzheaux for the feedback. PR's been updated

@jzheaux jzheaux merged commit a106188 into spring-projects:5.7.x Mar 27, 2023
@jzheaux
Copy link
Contributor

jzheaux commented Mar 27, 2023

Thanks, @tatisled! This is now merged into 5.7.x, 5.8.x, 6.0.x, and main.

@jzheaux jzheaux added this to the 5.7.8 milestone Mar 27, 2023
@tatisled tatisled deleted the tatisled/add-nameIdFormat-to-saml-auth-request branch March 29, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: saml2 An issue in SAML2 modules status: duplicate A duplicate of another issue type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants