Skip to content

Conversation

@ghaege
Copy link

@ghaege ghaege commented Jan 19, 2023

No description provided.

@pivotal-cla
Copy link

@ghaege Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 19, 2023
@pivotal-cla
Copy link

@ghaege Thank you for signing the Contributor License Agreement!

@sjohnr sjohnr added type: enhancement A general enhancement in: saml2 An issue in SAML2 modules labels Jan 20, 2023
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ghaege! New features need to go into the latest minor release, so will you please rebase on main so that this goes out in 6.1?

Also, will you please update your commit messages in the following two ways:

  • The title should be in the present tense and should probably say "Add" instead of "Fix" (since this is new behavior)
  • The commit message should have "Closes gh-12538" at the bottom, like this:
Add RelayState Customizer to SAML Logout

Closes gh-12538

@ghaege
Copy link
Author

ghaege commented Jan 25, 2023

replaced by #12582

@ghaege ghaege closed this Jan 25, 2023
@ghaege ghaege deleted the gh-12538-custom-relaystate-saml-logout branch January 25, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: saml2 An issue in SAML2 modules status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants