Remove accidental characters in sample's pom.xml #651
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much, @izeye. I'm rather amazed that the sample still built with that extra |
wilkinsona
added
type: task
wilkinsona
pushed a commit
that referenced
this pull request
Oct 17, 2019
|
@wilkinsona My pleasure 😄 By the way did you find how the builds have passed with them before? I'm curious as I just imagined that the sample hasn't been included in the builds somehow when I was opening this PR in my iPad. |
|
I haven't figured it out, but I did confirm that the sample builds fine locally with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes accidental characters in sample's
pom.xmlas it seems to be introduced accidentally.