Provide default port / scheme information in documentation #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a note about default ports 80 and 443 in combination with http or https scheme. Fixes spring-projectsgh-325
Contributor
Author
|
Since there is a build failure with the maven sample, should I do the PR against the 1.1.x branch? |
Member
|
Thanks for the PR. I'm not sure what's wrong with Travis and haven't had time to investigate. The build's green on Bamboo. A change to base off 1.1.x would be great please. That's the branch where I'd like this to land. |
Member
|
Closing in favour of #329 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a note about default ports 80 and 443 in combination with http or https scheme.
Fixes gh-325