DefaultObjectDirectoryMapper should use DefaultConversionService

[Enrice]

I just switched from Version 3.2.12 to 3.3.0 and it broke my code, I got:
org.springframework.ldap.odm.core.impl.InvalidEntryException: Missing converter from class java.lang.String to class java.lang.Long, this is needed for field xxx on Entry class Yyy.

The reason seems to be different default converters are used now:

spring-ldap/core/src/main/java/org/springframework/ldap/odm/core/impl/DefaultObjectDirectoryMapper.java

Line 81 in 84f6432

GenericConversionService conversionService = new GenericConversionService();

is creating a org.springframework.core.convert.support.GenericConversionService whereas it used to be a org.springframework.core.convert.support.DefaultConversionService which actually CAN convert String to Long.

[Enrice]

To work around this I tried to use DefaultConversionService instead, which is also not a good replacement, because it lacks a StringToNameConverter which has been added by the now deprecated ConversionServiceConverterManager.

I COULD of course write my own ConversionService to have the best of both worlds, but this seems overly verbose to me.

[fanonwue]

More of a workaround, but you can use ConverterUtils.addDefaultConverters(conversionService) to add Spring LDAP's default converters to any conversion service. This is how DefaultDirectoryMapper does it:

private static ConverterManager createDefaultConverterManager() {
	GenericConversionService conversionService = new GenericConversionService();
	ConverterUtils.addDefaultConverters(conversionService);
	return new ConversionServiceConverterManager(conversionService);
}

You then need to provide your own converters, but converting a string to int/long and vice versa is trivial. Here's an example from my (Kotlin) codebase (using DefaultConversionService, which includes those converters):

@Bean
fun objectDirectoryMapper() = DefaultObjectDirectoryMapper().apply {
    val conversionService = DefaultConversionService()
    ConverterUtils.addDefaultConverters(conversionService)
    this.setConversionService(conversionService)
}

@Bean
fun ldapTemplate(
    contextSource: ContextSource, 
    objectDirectoryMapper: ObjectDirectoryMapper
) = LdapTemplate(contextSource).apply {
    setIgnorePartialResultException(true)
    this.objectDirectoryMapper = objectDirectoryMapper
}

[Enrice]

Well, as I said, my workaround was even easier (more or less the same as yours):

public class LdapConversionService extends DefaultConversionService {
    public LdapConversionService() {
        ConverterUtils.addDefaultConverters(this);
    }
}

but I am still not convinced...

[jzheaux]

Thanks for the report, @Enrice. This has been prioritized for the next maintenance release.