GH-2214: Fix Manual Nack with Zero Sleep #2215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves spring-projects#2214 Regression; manual nack with zero sleep went into a tight loop since 2.8.4. Add a copy of the current test, with a zero sleep; also verify that nacking the first and last records work. **cherry-pick to 2.9.x, 2.8.x**
artembilan
requested changes
Apr 6, 2022
| factory.setConsumerFactory(consumerFactory()); | ||
| factory.getContainerProperties().setAckMode(AckMode.MANUAL); | ||
| factory.getContainerProperties().setMissingTopicsFatal(false); | ||
| factory.setRecordInterceptor(new RecordInterceptor() { |
Member
There was a problem hiding this comment.
Do we really need this interceptor to be copied in this test scope?
I had a pain back-porting it yesterday for other test class: some API changes in Kafka client.
Thanks
Contributor
Author
There was a problem hiding this comment.
No; just a copy/paste artifact; will remove.
Member
|
... and cherry-picked to |
|
hi, i left question there: #2214 (comment) but i feel this is better place to ask |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2214
Regression; manual nack with zero sleep went into a tight loop since
2.8.4.
Add a copy of the current test, with a zero sleep; also verify that
nacking the first and last records work.
cherry-pick to 2.9.x, 2.8.x