Reduce instance supplier use to appease AOT #8568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
commented
Mar 2, 2023
.../java/org/springframework/integration/config/DefaultConfiguringBeanFactoryPostProcessor.java
Show resolved
Hide resolved
onobc
commented
Mar 2, 2023
.../main/java/org/springframework/integration/dsl/context/IntegrationFlowBeanPostProcessor.java
Outdated
Show resolved
Hide resolved
artembilan
requested changes
Mar 2, 2023
Member
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
Thank you, Chris!
Just a couple requests to restore existing behavior in your change.
The mostly important concern that we would like to deal with existing instances in those bean definitions, but not creating new as it would be with a default class-based configuration.
.../main/java/org/springframework/integration/config/AbstractMethodAnnotationPostProcessor.java
Outdated
Show resolved
Hide resolved
...ava/org/springframework/integration/config/InboundChannelAdapterAnnotationPostProcessor.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/integration/dsl/context/IntegrationFlowBeanPostProcessor.java
Outdated
Show resolved
Hide resolved
* Remove the use of instance suppliers on bean definitions that are processed during the AOT phase. * The remaining areas that use instance suppliers do so at runtime and do not use reflection, but instead are passed the configured bean to register. See spring-cloud/spring-cloud-stream#2655
onobc
force-pushed
the
cbono-remove-instance-suppliers
branch
from
dbd785c to
bc92c49
Compare
Member
|
... and cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the use of instance suppliers on bean definitions that are processed during the AOT phase.
The remaining areas that use instance suppliers do so at runtime and do not use reflection, but instead
are passed the configured bean to register.
See spring-cloud/spring-cloud-stream#2655