GH-3733 Configure TxManager for DefLockRepository #3782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#3733 The `@Transactional` resolves a primary `TransactionManager` bean from the application context which might not be sufficient for all the use-case. To make it work with the custom (or specific) `TransactionManager` we have to extend a `DefaultLockRepository` and override all those `@Transactional` method * Change the logic of the `DefaultLockRepository` from `@Transactional` to the `TransactionTemplate` and use provided `TransactionManager` or resolve one from the application context * Adjust tests to use explicit `TransactionManager` and call `afterSingletonsInstantiated()` to initialize a default `TransactionTemplate` * Mention the change in the docs
garyrussell
suggested changes
Apr 12, 2022
| @Override | ||
| public void afterSingletonsInstantiated() { | ||
| if (this.transactionManager == null) { | ||
| this.transactionManager = this.applicationContext.getBean(PlatformTransactionManager.class); |
Contributor
There was a problem hiding this comment.
Maybe try/catch with a friendly message to indicate if there is not one unique TM in the context, the registry needs one to be passed in?
| DefaultTransactionDefinition transactionDefinition = | ||
| new DefaultTransactionDefinition(TransactionDefinition.PROPAGATION_REQUIRES_NEW); | ||
| transactionDefinition.setIsolationLevel(TransactionDefinition.ISOLATION_SERIALIZABLE); | ||
| return new TransactionTemplate(this.transactionManager, transactionDefinition) |
Contributor
There was a problem hiding this comment.
Can't we store this template in a field too?
| } | ||
| DefaultTransactionDefinition transactionDefinition = | ||
| new DefaultTransactionDefinition(TransactionDefinition.PROPAGATION_REQUIRES_NEW); | ||
| transactionDefinition.setIsolationLevel(TransactionDefinition.ISOLATION_SERIALIZABLE); |
* Add `BeanInitializationException` for no-unique `PlatformTransactionManager` bean in the `afterSingletonsInstantiated()`
garyrussell
suggested changes
Apr 12, 2022
...tion-jdbc/src/main/java/org/springframework/integration/jdbc/lock/DefaultLockRepository.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Gary Russell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3733
The
@Transactionalresolves a primaryTransactionManagerbeanfrom the application context which might not be sufficient for all
the use-case.
To make it work with the custom (or specific)
TransactionManagerwe have to extend a
DefaultLockRepositoryand override all those@TransactionalmethodDefaultLockRepositoryfrom@Transactionalto the
TransactionTemplateand use providedTransactionManageror resolve one from the application context
TransactionManagerand callafterSingletonsInstantiated()to initialize a defaultTransactionTemplate