Cancel subscription for MPS.subscribeToPublisher #3749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Flux.takeWhile()` only works if there is data in the `Publisher` to consume. We still need to be able to cancel subscription and stop producing even if there is no data at the moment. * Change `takeWhile()` to the `doOnSubscribe()` and store `subscription` in the `volatile` property of the `MessageProducerSupport` * Cancel such a subscription in the `doStop()` impl * Propagate `doStop()` to super in the `ZeroMqMessageProducer` which is only one reactive channel adapter overriding `doStop()` * Verify in the `ReactiveMessageProducerTests` that subscription is cancelled for delayed data in the `Publisher` **Cherry-pick to `5.5.x`**
garyrussell
suggested changes
Mar 16, 2022
| */ | ||
| @Override | ||
| protected void doStop() { | ||
| Subscription subscriptionToCancel = this.subscription; |
Contributor
There was a problem hiding this comment.
synchronized ? Or is cancel idempotent?
Member
Author
There was a problem hiding this comment.
The stop() is synchronized via lifecycleLock in the AbstractEndpoint.
I don't believe anyone is going to call this protected doStop() directly.
garyrussell
approved these changes
Mar 16, 2022
Contributor
|
...and cherry-picked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Flux.takeWhile()only works if there is data in thePublisherto consume.
We still need to be able to cancel subscription and stop producing even if
there is no data at the moment.
takeWhile()to thedoOnSubscribe()and storesubscriptionin the
volatileproperty of theMessageProducerSupportdoStop()impldoStop()to super in theZeroMqMessageProducerwhich is only one reactive channel adapter overriding
doStop()ReactiveMessageProducerTeststhat subscription is cancelledfor delayed data in the
PublisherCherry-pick to
5.5.x