Skip to content

GH-10083: Apply Nullability to core dispatcher package #10272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 29, 2025
Merged

GH-10083: Apply Nullability to core dispatcher package #10272

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5cabe3c
GH-10083: Apply Nullability to core dispatcher package
cppwfs Jul 22, 2025
3939ef1
Due to the high use of the `dispatch` method it is better to suppress…
cppwfs Jul 28, 2025
b0ecd6e
Add comment to `PartitionedDispatcher.dispatch` stating why a `@Suppr…
cppwfs Jul 28, 2025
2044342
Correct comment PartitionedDispatcher.dispatch to state that partitio…
cppwfs Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...-core/src/main/java/org/springframework/integration/dispatcher/PartitionedDispatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ public void shutdown() {
}

@Override
@SuppressWarnings("NullAway")
@SuppressWarnings("NullAway") // Dataflow analysis limitation!
Copy link
Member

@artembilan artembilan Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... That's not what I meant, especially not with a ! 😉
How about this?

Suggested change
@SuppressWarnings("NullAway") // Dataflow analysis limitation!
@SuppressWarnings("NullAway") // The partitions map never returns null according to partition hash

Copy link
Contributor Author

@cppwfs cppwfs Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification. I thought that message was a bit terse. will update.

public boolean dispatch(Message<?> message) {
populatedPartitions();
int partition = Math.abs(this.partitionKeyFunction.apply(message).hashCode()) % this.partitionCount;
Expand Down