Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RepresentationModelProcessor to smoothly register with Spring MVC. #859

Closed
wants to merge 2 commits into from

Conversation

gregturn
Copy link
Contributor

@gregturn gregturn commented Mar 7, 2019

Some more polishing on internal of Processor and Invoker machinery regarding resource -> model, etc.

@gregturn gregturn force-pushed the bug/resource-processors branch from 2c90de7 to 9f10970 Compare March 7, 2019 20:53
gregturn added a commit that referenced this pull request Mar 7, 2019
…ing MVC.

Some more polishing on internal of Processor and Invoker machinery regarding resource -> model, etc.
@gregturn gregturn requested a review from odrotbohm March 7, 2019 20:54
@gregturn gregturn added this to the 1.0 M2 milestone Mar 7, 2019
@gregturn gregturn force-pushed the bug/resource-processors branch from 9f10970 to fa50271 Compare March 23, 2019 02:43
gregturn added a commit that referenced this pull request Mar 23, 2019
…ing MVC.

Some more polishing on internal of Processor and Invoker machinery regarding resource -> model, etc.
@gregturn gregturn added the in: core Core parts of the project label Mar 23, 2019
…ing MVC.

Some more polishing on internal of Processor and Invoker machinery regarding resource -> model, etc.
@gregturn gregturn force-pushed the bug/resource-processors branch from f5ac35d to 504729e Compare April 3, 2019 17:49
@gregturn gregturn requested a review from schauder April 3, 2019 17:55
Changed http urls to https.
Minor changes to formatting.
Copy link
Contributor

@schauder schauder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests need to be changed to JUnit 5.

Other than that and the small changes I did in a polishing commit I'm fine with this change.

gregturn added a commit that referenced this pull request Apr 18, 2019
…ing MVC.

Some more polishing on internal of Processor and Invoker machinery regarding resource -> model, etc.
gregturn pushed a commit that referenced this pull request Apr 18, 2019
Changed http urls to https.
Minor changes to formatting.
gregturn added a commit that referenced this pull request Apr 18, 2019
@gregturn
Copy link
Contributor Author

Resolved via f192b2d, 75b5183, and 70ebff9.

@gregturn gregturn closed this Apr 18, 2019
@gregturn gregturn deleted the bug/resource-processors branch April 18, 2019 19:35
odrotbohm pushed a commit that referenced this pull request May 8, 2019
…ing MVC.

Some more polishing on internal of Processor and Invoker machinery regarding resource -> model, etc.
odrotbohm pushed a commit that referenced this pull request May 8, 2019
Changed http urls to https.
Minor changes to formatting.
odrotbohm pushed a commit that referenced this pull request May 8, 2019
odrotbohm added a commit that referenced this pull request Jul 1, 2019
Removed System.our.println from test case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Core parts of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants