Refactor: Replace hardcoded '.' with EXTENSION_SEPARATOR in StringUtils #33645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced all instances of the hardcoded '.' character with the EXTENSION_SEPARATOR constant in the StringUtils class. This refactor improves the code's readability and maintainability by ensuring that separator characters are defined consistently through the use of constants. No functional changes have been made.
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks but in both cases the "." characters are not extension separators but have other meaning. |
bclozel
added
status: declined
|
Thank you for your comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
StringUtilsclass by substituting all occurrences of the hardcoded'.'character with the already-defined constantEXTENSION_SEPARATOR. This refactor promotes cleaner code by removing magic values and enhancing maintainability, as separator characters are now managed centrally. Additionally, this change minimizes the risk of errors that may arise from inconsistent use of the'.'character throughout the codebase.No changes have been made to the functionality of the methods, ensuring that the behavior remains intact.