-
Notifications
You must be signed in to change notification settings - Fork 38.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Publisher to InputStream conversion #31677
Closed
OlegDokuka
wants to merge
4
commits into
spring-projects:main
from
OlegDokuka:main-input-stream-subscriber
Closed
Support Publisher to InputStream conversion #31677
OlegDokuka
wants to merge
4
commits into
spring-projects:main
from
OlegDokuka:main-input-stream-subscriber
+1,235
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged or decided on
label
Nov 24, 2023
ConcurrentLinkedQueue may produce more garbage compared to the BlockingArrayQueue array based alternative
poutsma
added
in: web
Issues in web modules (web, webmvc, webflux, websocket)
type: enhancement
A general enhancement
and removed
status: waiting-for-triage
An issue we've not yet triaged or decided on
labels
Jan 17, 2024
rstoyanchev
changed the title
adds support for PublisherToInputStream conversion
Support Publisher to InputStream conversion
Sep 24, 2024
rstoyanchev
pushed a commit
that referenced
this pull request
Oct 28, 2024
rstoyanchev
added a commit
that referenced
this pull request
Oct 28, 2024
There are legitimate differences, but also some are fixes that should be on both sides. See gh-31677
rstoyanchev
added a commit
that referenced
this pull request
Oct 28, 2024
rstoyanchev
added a commit
that referenced
this pull request
Oct 28, 2024
rstoyanchev
added a commit
that referenced
this pull request
Oct 28, 2024
It is both, but InputStream is what's exposed for public use, in effect an InputStream backed by a Subscriber source. See gh-31677
rstoyanchev
added a commit
that referenced
this pull request
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
in: web
Issues in web modules (web, webmvc, webflux, websocket)
type: enhancement
A general enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduced support for Publisher to InputStream conversion