Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support WritableResource property values #301

Closed
wants to merge 1 commit into from
Closed

Support WritableResource property values #301

wants to merge 1 commit into from

Conversation

philwebb
Copy link
Member

Update DefaultResourceLoader to always attempt FileResource resolution
before URLResource, allowing casting of the result to WritableResource.

Also update ResourceEditorRegistrar to register a property editor for
WritableResources.

Issue:

@philwebb
Support WritableResource property values
8151a57 
Update DefaultResourceLoader to always attempt FileResource resolution
before URLResource, allowing casting of the result to WritableResource.

Also update ResourceEditorRegistrar to register a property editor for
WritableResources.

Issue: SPR-10656
@ghost ghost assigned jhoeller Jun 24, 2013
@cbeams
Copy link
Contributor

cbeams commented Jun 24, 2013

Hey @philwebb, I don't know the larger context here, but thought I'd check: are you aware that FilesystemResourceLoader already attempts FileResources by default?

@philwebb
Copy link
Member Author

I see that is the case for paths starting with '/'. The context here is supporting:

@Value("file:/some/file") WritableResource resource.

Currently the above will only work with Resource

@spring-projects-issues spring-projects-issues mentioned this pull request Jan 11, 2019
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 24, 2019
@rstoyanchev rstoyanchev added the in: core Issues in core modules (aop, beans, core, context, expression) label Nov 12, 2021
@snicoll
Copy link
Member

snicoll commented Dec 3, 2021

Sorry this was overlooked for so long @philwebb. This got superseded in the meantime as of 5.0.2.

@snicoll snicoll closed this Dec 3, 2021
@snicoll snicoll added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@philwebb @cbeams @snicoll @rstoyanchev @jhoeller @spring-projects-issues