Fix BindingResult error when ModelAttribute has custom name in WebFlux #28422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bougar Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@bougar Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
the
in: web
sbrannen
changed the title
sbrannen
added
type: bug
sbrannen
changed the title
sbrannen
changed the title
sbrannen
added a commit
that referenced
this pull request
May 7, 2022
|
Good catch! This has been merged into Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess this part of the code is trying to get the
ModelAttributeannotation from theBindingResultparameter itself instead of the previous one as it should be. This is causingannvariable to be alwaysnulland therefore ignoring the value of the@ModelAttributeannotation.