Fix response body missing 1st byte inside UnknownContentTypeException #27374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the creation of UnknownContentTypeException when it is thrown from HttpMessageConverterExtractor.extractData. This exception is usually thrown from RestTemplate when HttpMessageConverterExtractor can't extract response body. In this case HttpMessageConverterExtractor throws UnknownContentTypeException with response body as byte array. Before this change the returned exception contained incorrect responseBody when InputStream from ClientHttpResponse was not markable (markSupported is false). This is the usual case for HTTP response's InputStream implementations. The first byte of response body inside UnknownContentTypeException was missing because it was already read from InputStream. The responseBody was read from original InputStream, while it should be read from the wrapper of original InputStream. This commit fixes this.
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
in: web
rstoyanchev
added a commit
that referenced
this pull request
Sep 10, 2021
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this pull request
Mar 26, 2022
HttpMessageConverterExtractor uses MessageBodyClientHttpResponseWrapper which may read the first byte of the response stream to check if there is content. After that it is necessary to use the wrapper to get the full body. This commit ensures that when UnknownContentTypeException is raised it gets the body through the wrapper, or otherwise the first byte is missed if the InputStream is not markable. Closes spring-projectsgh-27374
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this pull request
Mar 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the creation of
UnknownContentTypeExceptionwhen it is thrown fromHttpMessageConverterExtractor.extractData.This exception is usually thrown from
RestTemplatewhenHttpMessageConverterExtractorcan't extract response body.In this case
HttpMessageConverterExtractorthrowsUnknownContentTypeExceptionwith response body as byte array.Before this change the returned exception contained incorrect
responseBodywhenInputStreamfromClientHttpResponsewas not markable (markSupported()is false). This is the usual case for HTTP response'sInputStreamimplementations.The first byte of response body inside
UnknownContentTypeExceptionwas missing because it was already read fromInputStream.The
responseBodywas read from originalInputStream, while it should be read from the wrapper of originalInputStream.To a person who will merge: please improve the commit message if possible as I feel difficulties in attempt to correctly and briefly describe the change, that is essentially a bug fix (not a native English speaker).