Skip to content

Clarify that ClientRequest.from(..) also copies body #27220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Clarify that ClientRequest.from(..) also copies body #27220

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3618557
Clarify that from(..) also copies body
AlexejTimonin Jul 28, 2021
0a0d6da
Test to show that body will be copied
AlexejTimonin Jul 28, 2021
8c00d5f
Include attributes in doc
AlexejTimonin Jul 30, 2021
bd3b3b8
Change copyright date
AlexejTimonin Jul 30, 2021
023752f
Update from() test to include attributes
AlexejTimonin Jul 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...webflux/src/main/java/org/springframework/web/reactive/function/client/ClientRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,8 @@ default Optional<Object> attribute(String name) {
// Static builder methods

/**
* Create a builder with the method, URI, headers, and cookies of the given request.
* @param other the request to copy the method, URI, headers, and cookies from
* Create a builder with the method, URI, headers, cookies and body of the given request.
* @param other the request to copy the method, URI, headers, cookies and body from
* @return the created builder
*/
static Builder from(ClientRequest other) {
Expand Down
29 changes: 29 additions & 0 deletions ...va/org/springframework/web/reactive/function/client/DefaultClientRequestBuilderTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,35 @@ public void from() throws URISyntaxException {
assertThat(result.httpRequest()).isNotNull();
}

@Test
public void fromCopiesBody() {
String body = "foo";
BodyInserter<String, ClientHttpRequest> inserter = (response, strategies) -> {
byte[] bodyBytes = body.getBytes(UTF_8);
DataBuffer buffer = DefaultDataBufferFactory.sharedInstance.wrap(bodyBytes);

return response.writeWith(Mono.just(buffer));
};

ClientRequest other = ClientRequest.create(POST, URI.create("https://example.com"))
.body(inserter).build();

ClientRequest result = ClientRequest.from(other).build();

List<HttpMessageWriter<?>> messageWriters = new ArrayList<>();
messageWriters.add(new EncoderHttpMessageWriter<>(CharSequenceEncoder.allMimeTypes()));

ExchangeStrategies strategies = mock(ExchangeStrategies.class);
given(strategies.messageWriters()).willReturn(messageWriters);

MockClientHttpRequest request = new MockClientHttpRequest(POST, "/");
result.writeTo(request, strategies).block();

String copiedBody = request.getBodyAsString().block();

assertThat(copiedBody).isEqualTo("foo");
}

@Test
public void method() throws URISyntaxException {
URI url = new URI("https://example.com");
Expand Down