Add ContentLength support for InputStreamResource created in ResourceHttpMessageConverter and ResourceDecoder #24292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support of HTTP Content-Length header to ResourceHttpMessageConverter for InputStreamResource Removed contentLength calculation for InputStreamResource in ResourceDecoder since size is always known
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
in: web
jhoeller
changed the title
rstoyanchev
pushed a commit
that referenced
this pull request
Jan 8, 2020
Expose the known content length, if known, in the InputStreamResource returned by ResourceHttpMessageConverter or ResourceDecoder. See gh-24292
rstoyanchev
added a commit
that referenced
this pull request
Jan 8, 2020
|
Thanks for the pull request. I made a small adjustment to fall back on the base class in case the content-length is not present. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
InputStreamResource created in ResourceHttpMessageConverter /ResourceDecoder doesn't properly support contentLength.
contentLength() method consumes input stream to calculate size instead of just providing predefined value.
Motivation
Streaming use case, where application acts as a proxy for large amount of data.
Fix
ResourceHttpMessageConverter should read HTTP Content-Length header.
ResourceDecoder creates ISR based on byte array, so size is always known.
Caveats
contentLength() for InputStreamResource created in ResourceHttpMessageConverter can be -1 if Content-Length header is missing.