Hoist Class.getName() from String concatenation to dodge an issue related to profile pollution #24153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated to profile pollution
spring-projects-issues
added
the
status: waiting-for-triage
jhoeller
added
in: core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On one of my projects I've run into performance issue related to profile polution when
Class.getName()is used inside of String concatenation chain. The issue is described here: https://stackoverflow.com/questions/59157085/java-8-class-getname-slows-down-string-concatenation-chainAs far as Spring is likely to remain on Java 8 code base I suggest to hoist Class.getName() from frequently executed concatenation chains at least from
ObjectUtils.identityToString()which is called from loop inDefaultListableBeanFactory.findAutowireCandidates()andSimpleTraceInterceptor.getInvocationDescription().