Polish MimeTypeUtil to handle only delimiter. #1016
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmyjoe
force-pushed
the
tmyjoe/polish-mimeutil
branch
from
d899abf to
b3bf6a6
Compare
Author: Tomoya Honjo <[email protected]>
tmyjoe
force-pushed
the
tmyjoe/polish-mimeutil
branch
from
b3bf6a6 to
39479f3
Compare
Author
|
I have signed and agree to the terms of the Spring Individual Contributor |
Contributor
|
Would you mind also creating a ticket in JIRA? |
Author
|
I've created a ticket for this. |
| if (!StringUtils.hasLength(mimeType)) { | ||
| throw new InvalidMimeTypeException(mimeType, "'mimeType' must not be empty"); | ||
| } | ||
| if (mimeType.startsWith(";")) { |
Contributor
There was a problem hiding this comment.
if (parts.length == 0) {
throw new InvalidMimeTypeException(mimeType, "'mimeType' must not be empty");
}
Contributor
|
Thanks for the PR. I've implemented as suggested by @ryanskow since that addresses the exact issue with the ArrayIndexOutOfBoundsException and more conclusively. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've encounter
java.lang.ArrayIndexOutOfBoundsException:when only ";" passed in Accept Header and foundMimeTypeUtilsthrows the exception.It think it's an unexpected behavior, so added a logic to throw the dedicated exception :)