WebUtils#extractFilenameFromUrlPath IndexOutOfBoundsException [SPR-5112]

[spring-projects-issues]

Zach Legein opened SPR-5112 and commented

A url like this will cause an error:

http://www.website.com/test.html?file=/path/to/file

My suggestion would be to do something like this:

    int begin = urlPath.indexOf("://");
    if (begin == -1) {
        return null;
    }

    String body = urlPath.substring(begin + "://".length(), urlPath.length());
    if (!body.contains("/")) {
        return null;
    }

    int end = urlPath.indexOf('?');
    if (end == -1) {
        end = urlPath.length();
    }

    String url = urlPath.substring(0, end);
    begin = url.lastIndexOf("/") + 1;
    String filename = url.substring(begin, url.length());
    int dotIndex = filename.lastIndexOf('.');
    if (dotIndex != -1) {
        filename = filename.substring(0, dotIndex);
    }
    return filename;

---

Affects: 2.5.5

[spring-projects-issues]

Juergen Hoeller commented

Note that extractFilenameFromUrlPath is only really intended to be called for URI parts, excluding the query string to begin with. That said - I've nevertheless addressed this for 2.5.6, properly checking for the last final path separator from the end of the actual URI part.

Juergen