Improve context-property-placeholder configurablity [SPR-4661]

[spring-projects-issues]

Marten Deinum opened SPR-4661 and commented

I was replacing our current PropertiesPlaceHolderConfigurer with a <context:property-placeholder but couldn't do that (whilst recommended by STS).

I need the 'ignoreResourceNotFound' property to be settable from the tag. Maybe some more options also depending on the tag (property-placholder or property-override).

---

Affects: 2.5.2

Attachments:

• AbstractPropertyLoadingBeanDefinitionParser.java (2.55 kB)
• patch-20090309.txt (7.45 kB)
• SPR-4661.2.patch (7.64 kB)
• SPR-4661.patch (3.00 kB)
• spring-context-2.5.xsd (14.84 kB)

Issue Links:

• Add more properties to <context:property-placeholder/> [SPR-5016] #9691 Add more properties to context:property-placeholder/ ("is duplicated by")

Referenced from: commits a29253f, 1a9599c, b250c65

12 votes, 8 watchers

[spring-projects-issues]

nicolas de loof commented

Also please add support for setting the systemPropertiesMode, and to use more than one location : for example the contexte may be configured using classpath:/default.properties + ${user.home}/custom.properties.

[spring-projects-issues]

Marten Deinum commented

Multiple properties files can already be specified, simply pass in a comma separated list of files. This is also documented in the reference guide.

[quote]
With the context namespace introduced in Spring 2.5, it is possible to configure property placeholders with a single element (and multiple locations may be provided as a comma-separated list):
[/quote]

[spring-projects-issues]

David J. M. Karlsen commented

Sure - probably a bad example - but there are other attributes, like:
system properties mode override
null value
pre- and postfix

etc

[spring-projects-issues]

David Pedowitz commented

Attempt to add properties available in PropertiesLoaderSupport PropertyResourceConfigurer to bean parser

[spring-projects-issues]

David Pedowitz commented

Updated context XSD with new attributes

[spring-projects-issues]

David Pedowitz commented

I took a stab at helping this feature, this is my first attempt to contribute some code to Spring so any feedback is welcome.

[spring-projects-issues]

David J. M. Karlsen commented

Patch to expose "nullValue" property

[spring-projects-issues]

David Pedowitz commented

Created combined patch with localOverride, ignoreResourceNotFound, fileEncoding, order and nullValue

[spring-projects-issues]

Ondra Žižka commented

Do I understand it well that this is going to be released in Spring 3.0, no sooner?

[spring-projects-issues]

David Pedowitz commented

Created new patch from trunk of 3.0

[spring-projects-issues]

Ken Krueger commented

David P, thanks for doing this, I was looking for the same thing and just about to open an issue. kudos

[spring-projects-issues]

Dave Syer commented

Added order, locations (via location attribute), system-properties-mode, ignore-*