NPE in AbstractRefreshableConfigApplicationContext#setConfigLocations [SPR-4531]

[spring-projects-issues]

Andreas Senft opened SPR-4531 and commented

The method setConfigLocations(String[]) has a problem which causes an NPE when the passed in array is null.
First a check is made whether the array contains nulls (correctly skipping processing if the array itself is null).
After that a String-array is created using the size of the passed in array. If that is null, an NPE results.

In conjunction with Apache CXF this is a problem as the SpringBusFactory#createBus() method of CXF does provide null as argument. This worked in Spring 2.5.1 as the class AbstractRefreshableConfigApplicationContext didn't exist there and the location setting has been handled differently.

---

Affects: 2.5.2

1 votes, 1 watchers

[spring-projects-issues]

Szczepan Kuzniarz commented

In Spring 2.5 and 2.5.1 configLocations array was trimmed using StringUtils.trimArrayElements (in ClassPathXmlApplicationContext(String[], boolean, ApplicationContext) constructor) and StringUtils.trimArrayElements returns zero-sized String array if its argument is null. Maybe AbstractRefreshableConfigApplicationContext.setConfigLocations should do the same?

[spring-projects-issues]

Juergen Hoeller commented

Thanks for pointing this out! I've restored support for a null location array argument in ClassPathXmlApplicationContext (equivalent to the original trimArrayElements behavior).

This will be available in tonight's 2.5.3 snapshot. Please give it a try and let me know whether it works for you (again)!

Juergen

[spring-projects-issues]

Andreas Senft commented

Thank you Jürgen. The fix works for me.

Regards,
Andreas

[spring-projects-issues]

Szczepan Kuzniarz commented

It works (tested with 20080312-431 build). Thanks (again :-)!