Doc: Execution order for aspectj aspects and <tx:annotation-driven> [SPR-3164]

[spring-projects-issues]

Dan Luputan opened SPR-3164 and commented

This is related to #7190, which is needed but not complete.

I have one aspectj around aspect (an exception handler) which has to surround the txn interceptor. So I make it implement Ordered and give an order value lower than the order attribute in the tx:annotation-driven.
Now, the org.springframework.aop.aspectj.autoproxy.AspectJPrecedenceComparator compares the advisor order and even if the txn advisor has the right order the exception handler advisor still has the max int order, so the order present in the advice is not used.

Since the documentation says the aspects implement Ordered to control the execution order this might also be a bug.
I tested with 2.0.3 build 104.

---

Affects: 2.0.3

Issue Links:

• Document the 'order' attribute of the <tx:annotation-driven> element. [SPR-3061] #7747 Document the 'order' attribute of the tx:annotation-driven element. ("depends on")

[spring-projects-issues]

Dan Luputan commented

Tested with build 105 and it works!. And it works also by using the @Order annotation in the aspectj advice.

[spring-projects-issues]

Juergen Hoeller commented

So you're saying the bug is not present in 2.0.3 build 105 and higher anymore, i.e. aspect ordering works correctly for you there?

Juergen

[spring-projects-issues]

Dan Luputan commented

Yes, it is working correctly; though, the documentation could be updated to state that the @Order annotation also works for advice ordering.
Thanks.

[spring-projects-issues]

Juergen Hoeller commented

OK, turning this into a documentation task then...

Juergen

[spring-projects-issues]

Alef Arendsen commented

Done, fixed for 2.0.3