NullPointerException thrown with RequestContextListener in Websphere WAS 6 (6.0.2.15 ) [SPR-3037]

[spring-projects-issues]

Thomas Hoppe opened SPR-3037 and commented

Using the following settings in web.xml to have the Spring context being created:

<listener>
	<listener-class>
		org.springframework.web.context.ContextLoaderListener
	</listener-class>
</listener>
<listener>
	<listener-class>
		org.springframework.web.context.request.RequestContextListener
	</listener-class>
</listener>

Results in the following error message on console for EVERY request:

[14.01.07 12:36:44:686 CET] 000000af WebApp E SRVE0026E: [Servlet-Fehler]-[Faces Servlet]: java.lang.NullPointerException
at org.springframework.web.context.request.RequestContextListener.requestDestroyed(RequestContextListener.java:73)
at com.ibm.ws.webcontainer.webapp.WebApp.notifyServletRequestDestroyed(WebApp.java(Compiled Code))
at com.ibm.ws.webcontainer.servlet.ServletWrapper.handleRequest(ServletWrapper.java:980)
at com.ibm.ws.webcontainer.webapp.WebApp.handleRequest(WebApp.java:3071)
at com.ibm.ws.webcontainer.webapp.WebGroup.handleRequest(WebGroup.java:236)
at com.ibm.ws.webcontainer.VirtualHost.handleRequest(VirtualHost.java:210)
at com.ibm.ws.webcontainer.WebContainer.handleRequest(WebContainer.java:1958)
at com.ibm.ws.webcontainer.channel.WCChannelLink.ready(WCChannelLink.java:89)
at com.ibm.ws.http.channel.inbound.impl.HttpInboundLink.handleDiscrimination(HttpInboundLink.java:472)
at com.ibm.ws.http.channel.inbound.impl.HttpInboundLink.handleNewInformation(HttpInboundLink.java:411)
at com.ibm.ws.http.channel.inbound.impl.HttpICLReadCallback.complete(HttpICLReadCallback.java:101)
at com.ibm.ws.tcp.channel.impl.WorkQueueManager.requestComplete(WorkQueueManager.java:566)
at com.ibm.ws.tcp.channel.impl.WorkQueueManager.attemptIO(WorkQueueManager.java(Compiled Code))
at com.ibm.ws.tcp.channel.impl.WorkQueueManager.workerRun(WorkQueueManager.java:952)
at com.ibm.ws.tcp.channel.impl.WorkQueueManager$Worker.run(WorkQueueManager.java:1039)
at com.ibm.ws.util.ThreadPool$Worker.run(ThreadPool.java(Compiled Code))

Interestingly, Spring seems to work just fine (Scoped beans etc.)

---

Affects: 2.0.2

[spring-projects-issues]

Juergen Hoeller commented

The NPE line number in the stacktrace looks a bit odd, since it points to an empty line in the source code. Anyway: This probably occurs when the servlet container executes the "requestDestroyed" callback in a different thread, i.e. not within the original request thread. To be able to support such a scenario, RequestContextListener exposes the RequestAttributes instance in a ServletRequest attribute now, and looks for that one on request completion. So even if the thread is different and hence the original thread-bound RequestAttributes instance not available anymore, we'll still be able to clean up properly (and in particular, not run into an NPE). When the next request comes in, a new RequestAttributes instance will be bound to the thread, replacing any previous instance.

Juergen

[spring-projects-issues]

Juergen Hoeller commented

This fix should be available in the next 2.0.3 snapshot (http://www.springframework.org/snapshots). Feel free to give this an early try!

Juergen

[spring-projects-issues]

Thomas Hoppe commented

Hi,

Great work, I think it works perfectly in the latest build.

thnaks