BeanDefinitionDecorator not being called when nested [SPR-2975]

[spring-projects-issues]

Yan Pujante opened SPR-2975 and commented

I created a BeanDefinitionDecorator which is associated to the 'config' element. I have the following example:

<bean id="b4.1" class="test.spring.TestSpring$Bean4">
<lin:config>
<property name="p1" value="v1"/>
</lin:config>
</bean>
<bean id="b9.3" class="test.spring.TestSpring$Bean9">
<property name="bean4">
<bean class="test.spring.TestSpring$Bean4">
<lin:config>
<property name="p1" value="v3"/>
</lin:config>
</bean>
</property>
</bean>
In the first example, my decorator gets invoked. In the second case it does not get invoked!

---

Affects: 2.0.1

Attachments:

• lispring.xsd (2.31 kB)
• test.spring (1.03 kB)

Issue Links:

• p namespace doesn't work for inner beans [SPR-2955] #7641 p namespace doesn't work for inner beans ("is depended on by")

[spring-projects-issues]

Yan Pujante commented

I attach the schema I am using

[spring-projects-issues]

Yan Pujante commented

Here is the test file containing what is described in the bug

[spring-projects-issues]

Yan Pujante commented

I looked at the source code (version 2.0.1). I think the problem is as follow:

In DefaultBeanDefinitionDocumentReader lines 163-171:
else if (DomUtils.nodeNameEquals(ele, BEAN_ELEMENT)) {
BeanDefinitionHolder bdHolder = delegate.parseBeanDefinitionElement(ele);
if (bdHolder != null) {
bdHolder = delegate.decorateBeanDefinitionIfRequired(ele, bdHolder);
// Register the final decorated instance.
BeanDefinitionReaderUtils.registerBeanDefinition(bdHolder, getReaderContext().getRegistry());
// Send registration event.
getReaderContext().fireComponentRegistered(new BeanComponentDefinition(bdHolder));
}

and in BeanDefinitionDelegate lines 346-348
else if (DomUtils.nodeNameEquals(ele, BEAN_ELEMENT)) {
return parseBeanDefinitionElement(ele, bd);
}

Note that the processing is totally different whether it is a bean at the root level (under <beans>) and the first code gets executed... as such the decorator is invoked. When the bean is a property sub element the second code gets executed and the decorator is never invoked...

[spring-projects-issues]

Juergen Hoeller commented

This has fortunately already been discovered and fixed, triggered by a report that the "p:" namespace (which is implemented through a BeanDefinitionDecorator) doesn't work for inner beans.

Please give one of the recent 2.0.2 snapshots (http://www.springframework.org/snapshots) a try!

Juergen

[spring-projects-issues]

Yan Pujante commented

I just verified with build2.0.2 (11222006) and it is indeed fixed!

Thanks!