Use Quartz's JobExecutionContext.getMergedJobDataMap() in QuartzJobBean [SPR-1595]

[spring-projects-issues]

Matt Magoffin opened SPR-1595 and commented

Needed to pass a Quartz job some trigger-specific data via the Scheduler.triggerJobWithVolatileTrigger(jobName,groupName,jobMap) method (Quartz 1.5), but found that the Spring QuartzJobBean calls

context.getJobDetail().getJobDataMap()

to set properties on the job instance, which ignores the jobDataMap passed in with the Trigger, and is available by calling

context.getMergedJobDataMap()

I was wondering if this might be more useful in general, to change QuartzJobBean to use getMergedJobDataMap() to set the property values of the job instance.

I believe this is a new feature of Quartz 1.5, and would not be available with Quartz 1.4, but perhaps Spring's QuartzJobBean could support using the getMergedJobDataMap() if it found Quartz 1.5 available.

---

Affects: 1.2.6

[spring-projects-issues]

Matt Magoffin commented

Here's an example of how the JobDetailBean's execute method could be written to support this:

public final void execute(JobExecutionContext context) throws JobExecutionException {
	try {
		BeanWrapper bw = new BeanWrapperImpl(this);
		MutablePropertyValues pvs = new MutablePropertyValues();
		pvs.addPropertyValues(context.getScheduler().getContext());
		
		// support Quartz 1.5 getMergedJobDataMap if available
		JobDataMap jobDataMap = null;
		try {
			Method mergedMapMethod = context.getClass().getMethod(
					"getMergedJobDataMap",new Class[0]);
			jobDataMap = (JobDataMap)mergedMapMethod.invoke(
					context,new Object[0]);
		} catch ( Exception e ) {
			// Quartz 1.5 method not available, revert to 1.4 method
			jobDataMap = context.getJobDetail().getJobDataMap();
		}
		pvs.addPropertyValues(jobDataMap);
		bw.setPropertyValues(pvs, true);
	}
	catch (SchedulerException ex) {
		throw new JobExecutionException(ex);
	}
	executeInternal(context);
}

[spring-projects-issues]

Juergen Hoeller commented

Thanks for the suggestion - I've refined QuartzJobBean to use getMergedJobDataMap() if available.

Juergen