Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase scope of regex pattern cache for the SpEL matches operator #30148

Closed
github-actions bot opened this issue Mar 20, 2023 · 0 comments
Closed

Increase scope of regex pattern cache for the SpEL matches operator #30148

github-actions bot opened this issue Mar 20, 2023 · 0 comments
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: backport An issue that is a backport of another issue to a maintenance branch type: enhancement A general enhancement
Milestone
5.2.23

Comments

@github-actions
Copy link
Contributor

Backport of gh-30140
@github-actions github-actions bot added in: core Issues in core modules (aop, beans, core, context, expression) type: backport An issue that is a backport of another issue to a maintenance branch type: enhancement A general enhancement labels Mar 20, 2023
@github-actions github-actions bot added this to the 5.2.23 milestone Mar 20, 2023
@sbrannen sbrannen self-assigned this Mar 20, 2023
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Mar 20, 2023
@sbrannen
Increase scope of regex pattern cache for the SpEL matches operator
52c93b1 
Prior to this commit, the pattern cache for the SpEL `matches` operator
only applied to expressions such as the following where the same
`matches` operator is invoked multiple times with different input:

  "map.keySet().?[#this matches '.+xyz']"

The pattern cache did not apply to expressions such as the following
where the same pattern ('.+xyz') is used in multiple `matches`
operations:

  "foo matches '.+xyz' AND bar matches '.+xyz'"

This commit addresses this by moving the instance of the pattern cache
map from OperatorMatches to InternalSpelExpressionParser so that the
cache can be reused for all `matches` operations for the given parser.

Closes spring-projectsgh-30148
lakeslove pushed a commit to lakeslove/spring-framework that referenced this issue Dec 28, 2024
@sbrannen @lakeslove
Increase scope of regex pattern cache for the SpEL matches operator
dbdf160 
Prior to this commit, the pattern cache for the SpEL `matches` operator
only applied to expressions such as the following where the same
`matches` operator is invoked multiple times with different input:

  "map.keySet().?[#this matches '.+xyz']"

The pattern cache did not apply to expressions such as the following
where the same pattern ('.+xyz') is used in multiple `matches`
operations:

  "foo matches '.+xyz' AND bar matches '.+xyz'"

This commit addresses this by moving the instance of the pattern cache
map from OperatorMatches to InternalSpelExpressionParser so that the
cache can be reused for all `matches` operations for the given parser.

Closes spring-projectsgh-30148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: backport An issue that is a backport of another issue to a maintenance branch type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.23
Development

No branches or pull requests
1 participant
@sbrannen