Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to AspectJ 1.9.8 GA #27416

Closed
bclozel opened this issue Sep 15, 2021 · 6 comments
Closed

Upgrade to AspectJ 1.9.8 GA #27416

bclozel opened this issue Sep 15, 2021 · 6 comments
Labels
type: dependency-upgrade A dependency upgrade
Milestone

Comments

@bclozel
Copy link
Member

bclozel commented Sep 15, 2021

This is the first version that officially supports JDK17 source and target compatibility level (see eclipse-aspectj/aspectj#79).

Right now, we've downgraded the language level to 1.8 in aspectj Gradle tasks. Closing this issue would involve reverting the changes to the compileAspectj and compileTestAspectj tasks in spring-aspects.gradle.

@bclozel bclozel added the type: dependency-upgrade A dependency upgrade label Sep 15, 2021
@bclozel bclozel added this to the 6.0 M1 milestone Sep 15, 2021
bclozel added a commit that referenced this issue Sep 15, 2021
AspectJ doesn't support JDK17 language level (yet).
For the time being, this commit is downgrading the language level for
the aspectJ generated classes to 1.8.

See gh-27416
@jhoeller
Copy link
Contributor

We're tracking the AspectJ 1.9.8 RCs in #27537 (for 6.0 M1), so I'm repurposing this ticket for AspectJ 1.9.8 GA (in 6.0 M2).

@jhoeller jhoeller modified the milestones: 6.0 M1, 6.0 M2 Dec 14, 2021
@jhoeller jhoeller changed the title Upgrade to AspectJ 1.9.8 Upgrade to AspectJ 1.9.8 GA Dec 14, 2021
@sbrannen sbrannen modified the milestones: 6.0.0-M2, 6.0.0-M3 Jan 11, 2022
@sbrannen
Copy link
Member

@snicoll snicoll changed the title Upgrade to AspectJ 1.9.8 GA Upgrade to AspectJ 1.9.8 Jan 14, 2022
@philjoseph
Copy link

Hello AspectJ team, so is the GA for version 1.9.8, that will be the first GA for Java 17, currently depending on the optimization @sbrannen mentioned 25 days ago ?

@kriegaex
Copy link
Contributor

kriegaex commented Feb 8, 2022

No @philjoseph, that optimisation is already merged. Actually, we had stable versions for 1.9.8 - currently RC3 - for a long time and could have declared any of them final. Actually, I wanted to celebrate my committer status for AspectJ by cutting the release, even though technically it is not necessary, because I can already deploy to Maven Central ob behalf of the organisation. I just cannot directly commit and always have to trigger Andy Clement to merge my PRs for every little commit. Because internal Eclipse processes are rather Byzyntine, I still do not have committer status for AspectJ proper (only for AJDT), so I simply did not "push the release button". Sorry to have no more exciting (feature-wise) or better justified excuse for you. Maybe I should just deploy a release. For further oprimisations (Andy fixed a few minor bugs since 1.9.8.RC3), there is always the next release. But if you simply want to use Java 17, just use RC3. It does not contain the optimisation you talked about yet, though. That will be in the next Maven Central version.

@kriegaex
Copy link
Contributor

kriegaex commented Feb 11, 2022

Release 1.9.8 is out, see also eclipse-aspectj/aspectj#121 and the release announcement I sent to the AspectJ users mailing list. Quote:

Dear AspectJ users,

we have just released 1.9.8 (yes, finally). It is available on Maven Central already. The AspectJ installer can be found on Aspectj.dev.

For more information, please read the release notes.

See AspectJ GitHub issue spring-projects/spring-framework#95 for more information and for an example project showing how to upgrade to the latest AspectJ version when using dev.aspectj:aspectj-maven-plugin:1.13.1.

Enjoy AspectJ!

The AspectJ team

@snicoll

This comment was marked as outdated.

@jhoeller jhoeller changed the title Upgrade to AspectJ 1.9.8 Upgrade to AspectJ 1.9.8 GA Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Development

No branches or pull requests

6 participants