Consistent use of Collection.toArray with zero-sized array argument [SPR-16523]

[spring-projects-issues]

Juergen Hoeller opened SPR-16523 and commented

Aligned with spring-projects/spring-boot#12160, let's revisit all the Collection.toArray call in the codebase and consistently use the toArray(new T[0]) pattern over pre-initialized arrays with a given length. In contrast to the established latter pattern, the former turns out to be more performant on modern JVMs since it doesn't initialize the array with null values first and allows for using efficient array cloning mechanisms underneath.

---

Affects: 5.0.4

Issue Links:

• Introduce null-safety of Spring Framework API [SPR-15540] #20099 Introduce null-safety of Spring Framework API

Referenced from: commits a5cbf5f

[spring-projects-issues]

Juergen Hoeller commented

We're also consistently using StringUtils.toStringArray and ClassUtils.toClassArray across the codebase now, as shortcuts with improved readability. ClassUtils.toClassArray was missed in the nullability revision and got aligned as a non-null variant a la StringUtils.toStringArray now.