Make formatter value configurable through Spring EL/Property PlaceHolder [SPR-15330]

[spring-projects-issues]

SASI PERI opened SPR-15330 and commented

Hello,
The issue that appears to be fixed here : #11747
is reoccurring in 4.3.4. We have a spring boot web app (spring cloud dependencies Camden-SR4)

We tried configuring spring datetime formatter through app.props and use it by "${...}", it throughs exact same exception as mentioned in the link above. It's not able to inject this property from app.props.

Can you please check if this feature/fix is been ported from spring 3 to 4 and later ?
Regards
Sasi Peri

---

Affects: 4.3.4

Attachments:

• test-spring-date-time.7z (49.27 kB)

Issue Links:

• Make formatter value configurable through Spring EL/Property PlaceHolder [SPR-7087] #11747 Make formatter value configurable through Spring EL/Property PlaceHolder

[spring-projects-issues]

Stéphane Nicoll commented

That feature was fixed in 3.0 over 5 years ago so there's no backport involved whatsoever. It might be an issue involving Spring Cloud and/or some customizations on your side so please share a sample that I can run myself to reproduce the problem.

[spring-projects-issues]

SASI PERI commented

Hello Nicoll,

Thanks for taking a look at it !

I am attaching a very simple basic spring boot application (Rest Controller) here, to demonstrate the error I see, when using ${...} value from app.props.
The endpoint to test is : http://localhost:8080/getNextDay/2009-01-02
Instead of using ${..} (by commenting line#36), and uncomment line # 33 (to use a constant value instead) it works as expected.

Note: In this sample application later version of boot (1.5.X), while original problem I described used 1.4.X.

Regards
Sasi Peri

[spring-projects-issues]

SASI PERI commented

The sample spring boot application is in the attachment: test-spring-date-time.7z

[spring-projects-issues]

Stéphane Nicoll commented

Right, I see. There is nothing in the linked issue that states you can use that in an MVC parameter argument. Juergen Hoeller, Rossen Stoyanchev do we actually support that?

@RequestMapping("/getNextDay/{aDate}")
public String getPodDetail(@DateTimeFormat(pattern = "${my-date-format}") @PathVariable("aDate") Date aDate) {
}

The formatter attempts to parse the date with the pattern as is (i.e. the value from the environment isn't used)

[spring-projects-issues]

Rossen Stoyanchev commented

hi Stéphane Nicoll, this should actually work. The exact place where it gets applied is DateTimeFormatAnnotationFormatterFactory#getFormatter. However in order for that to work when DefaultFormattingConversionService is initializing the formatter factory it should have the EmbeddedValueResolver. I put a break in FormattingConversionService#addFormatterForFieldAnnotation and when it was called on startup embeddedValueResolver was null.

For comparison with just Spring MVC you can debug MvcNamespaceTests#testDefaultConfig.

[spring-projects-issues]

Stéphane Nicoll commented

Thanks Rossen Stoyanchev, I've created a Spring Boot issue for this.

[spring-projects-issues]

SASI PERI commented

Hello Stephane,

Your last reply says "I have created Spring Boot Issue". But overall status shows it is resolved. Can you please confirm if this is fixed in some Spring Boot release ?

Regards
Sasi Peri

[spring-projects-issues]

Stéphane Nicoll commented

Please click on the link and watch that issue for update.