YAML + PropertyPlaceholderConfigurer needs to process non-String values as well [SPR-14737]

[spring-projects-issues]

Dennis Mellert opened SPR-14737 and commented

When loading a Yaml resource (using YamlPropertiesFactoryBean) and passing it to a PropertyPlaceholderConfigurer (using <property name="properties" ref="yamlProperties" />) only String in the Yaml are replaced correctly.

The Problem seems to be that org.springframework.beans.factory.config.PropertyResourceConfigurer.convertProperties(Properties) only handles Strings (String propertyValue = props.getProperty(propertyName);). Since the propertyValue is not a String in this case (as parsed from YamlPropertiesFactoryBean, the method call returns null.

Workaround: Overriding convertProperties and dealing with propertyValues as Object: (Object propertyValue = props.get(propertyName);

---

Affects: 4.3.3

Issue Links:

• mergePropertiesIntoMap only works with String [SPR-5669] #10340 mergePropertiesIntoMap only works with String
• Allow YamlProcessor subclasses to build the flattened map [SPR-12499] #17104 Allow YamlProcessor subclasses to build the flattened map
• YamlPropertiesFactoryBean loses entries in the YAML document that have an empty array value [SPR-16769] #21310 YamlPropertiesFactoryBean loses entries in the YAML document that have an empty array value

Referenced from: commits 74c6188, 3346c59

[spring-projects-issues]

Juergen Hoeller commented

Good point. I've approached this a bit differently: YamlPropertiesFactoryBean exposes a Properties object with an overridden getProperty method which consistently exposes stringified representations now instead of silently swallowing non-String values.