ConcurrentMapCacheManager's storeByValue does not pick up ClassLoader [SPR-14314]

[spring-projects-issues]

Kazuki Shimizu opened SPR-14314 and commented

I've tried a new feature of cacheing supported at Spring 4.3.
I've used the storeByValue property of ConcurrentMapCacheManager as follow:

@EnableCaching
@Configuration
public class CacheConfig {
    @Bean
    CacheManager cacheManager() {
        ConcurrentMapCacheManager cacheManager = new ConcurrentMapCacheManager("configs");
        cacheManager.setStoreByValue(true);
        return cacheManager;
    }
}

However, it does not worked serialization and deserialization a cache value :(
Is my configuration wrong ?

I've tried as follow, it work fine. I want to know best configuration for this case.

@EnableCaching
@Configuration
public class CacheConfig implements BeanClassLoaderAware { // Add

    ClassLoader classLoader;

    @Override
    public void setBeanClassLoader(ClassLoader classLoader) {
        this.classLoader = classLoader;
    }

    @Bean
    CacheManager cacheManager() {
        ConcurrentMapCacheManager cacheManager = new ConcurrentMapCacheManager("configs");
        cacheManager.setBeanClassLoader(classLoader); // Add
        cacheManager.setStoreByValue(true);
        return cacheManager;
    }

}

---

Affects: 4.3 RC2

Issue Links:

• Support store-by-value in ConcurrentMapCacheManager [SPR-13758] #18331 Support store-by-value in ConcurrentMapCacheManager

[spring-projects-issues]

Stéphane Nicoll commented

The classloader callback interface hasn't been invoked yet so any attempt to actually enable the flag won't work. We should defer the creation of the caches once the bean is fully initialized or find another way to deal with this.

[spring-projects-issues]

Juergen Hoeller commented

We're recreating existing caches in setBeanClassLoaderAware now when in store-by-value mode.