SpEL Compiler: problems using primitives with instanceof operator [SPR-14250]

[spring-projects-issues]

Andy Clement opened SPR-14250 and commented

These two expressions generate bad code when compiled, for slightly different reasons:

3 instanceof T(Integer)
'foo' instanceof T(int)

The first because we didn't box the 3 in the OperatorInstanceOf.generateCode method. The second because primitive types used with instanceof need special handling. (Uncovered whilst testing some docs that Stephane referenced in another bug #18816)

---

Affects: 4.3 RC1

Issue Links:

• Review SpeL relational operators documentation [SPR-14243] #18816 Review SpeL relational operators documentation

Referenced from: commits a31f0bb

[spring-projects-issues]

Andy Clement commented

Fixes pushed. All scenarios now handled better:

• primitive on left of instanceof
• right hand side is a primitive type reference
• right hand side is not a 'direct' type reference (but instead something indirect like a variable reference).