AsyncResult calls SuccessCallback when it should call FailureCallback [SPR-14249]

[spring-projects-issues]

Sven Zethelius opened SPR-14249 and commented

If the AsyncResult was created with AsyncResult.forExecutionException(Throwable), then you try to add callback with AsyncResult.addCallback(ListenableFutureCallback<? super V>), onSuccess(null) is called instead of onFailure(throwable).

@Override
public void addCallback(SuccessCallback<? super V> successCallback, FailureCallback failureCallback) {
try {
// This needs to check if this.executionException != null here and call onFailure instead
successCallback.onSuccess(this.value);
}
catch (Throwable ex) {
failureCallback.onFailure(ex);
}
}

---

Affects: 4.2.5

Issue Links:

• ListenableFutureAdapter.addCallback may or may not propagate failures from a FailureCallback in the calling thread [SPR-13785] #18358 ListenableFutureAdapter.addCallback may or may not propagate failures from a FailureCallback in the calling thread
• AsyncResult implementation does not allow for throwing ExecutionException [SPR-13076] #17668 AsyncResult implementation does not allow for throwing ExecutionException

Referenced from: commits 1b1aac9, 5fc0d43

[spring-projects-issues]

Juergen Hoeller commented

This is effectively fixed in 4.3 already, as a consequence of the refinements behind #18358 (which primarily deal with consistent exception handling for onSuccess callback failures).

In any case, the particular issue here seems worth fixing in 4.2.6 as well, so I'll backport the explicit exception check (while preserving the general onSuccess exception handling in 4.2.x).