Allow non-public @Transactional test methods [SPR-14000]

[spring-projects-issues]

Sam Brannen opened SPR-14000 and commented

Overview

TestNG has never required that @Test methods be public. Furthermore, the upcoming JUnit 5 also no longer requires that test methods be public.

The Spring TestContext Framework (TCF) should therefore also not require that test methods are public.

Analysis

The TCF in fact does not require that test methods are public, since this is the responsibility of the underlying testing framework (e.g., JUnit or TestNG); however, it is currently not possible to have a @Transactional test method be non-public. The reason is that AnnotationTransactionAttributeSource is by default configured to ignore non-public methods.

Deliverables

1. Ensure that @Transactional test methods are not required to be public

---

Affects: 3.2.16

Issue Links:

• Support @BeforeTransaction and AfterTransaction on non-public methods [SPR-13997] #18570 Support @BeforeTransaction and AfterTransaction on non-public methods

Referenced from: commits df7b24b

[spring-projects-issues]

Sam Brannen commented

Completed as described in GitHub commit df7b24b:

Allow non-public @Transactional test methods

Prior to this commit, the TransactionalTestExecutionListener required
@Transactional test methods to be public; however, neither TestNG nor
JUnit 5 require that @Test methods are public. Consequently, non-public
transactional test methods silently run without a transaction.

This commit removes the 'public' restriction on transactional test
methods by setting the 'publicMethodsOnly' flag in
AnnotationTransactionAttributeSource to false.