(Web)MergedContextConfiguration.equals is not symmetrical [SPR-13951]

[spring-projects-issues]

Phil Webb opened SPR-13951 and commented

Currently MergedContextConfiguration.equals includes the following line:

if (!(other instanceof MergedContextConfiguration)) {
	return false;
}

I think it should be

if (!(other.getClass().equals(getClass())) {
	return false;
}

Since it's used as a cache key, i.e.:

MergedContextConfiguration c = ...
WebMergedContextConfiguration w = ...

w.equals(c); // false
c.equals(w); // true;

---

Affects: 4.2.4

Referenced from: commits ac44f9e, 659e441