Provide empty Model to @ExceptionHandler methods [SPR-13546]

[spring-projects-issues]

Kazuki Shimizu opened SPR-13546 and commented

Currently, when i want to add a object into the Model, i implements as returning the ModelAndView object from @ExceptionHandler method as follow.

@ExceptionHandler
@ResponseStatus(HttpStatus.INTERNAL_SERVER_ERROR)
public ModelAndView handleException(Exception e) {
	ModelAndView mav = new ModelAndView("error/systemError");
	mav.getModelMap().addAttribute("message", e.getMessage());
	return mav;
}

I want to use the Model at @ExceptionHandler method argument instead of ModelAndView by default as follow.

@ExceptionHandler
@ResponseStatus(HttpStatus.INTERNAL_SERVER_ERROR)
public String handleException(Exception e, Model model) {
	model.addAttribute("message", e.getMessage());
	return "error/systemError";
}

How do think ?
I submit PR at later.

---

Affects: 4.2.1

Referenced from: pull request #883, and commits 4391b29, 44b76d3

[spring-projects-issues]

Kazuki Shimizu commented

I've submit the PR.

[spring-projects-issues]

Juergen Hoeller commented

Good point, that's a gap that's easy enough to close.
Addressed for 4.2.2 now, in a slightly revised fashion.

Juergen

[spring-projects-issues]

Kazuki Shimizu commented

Hi Juergen Hoeller, thanks for polishing and merging.
I'm happy :)

[spring-projects-issues]

Rossen Stoyanchev commented

This makes sense as long as there is no expectation for this to be the same model the controller method would have had access to. Clearly not the request here but worth updating the Javadoc for @ExceptionHandler.

[spring-projects-issues]

Sam Brannen commented

I agree with Rossen. If it's not clearly documented (at least in the Javadoc but preferably also in the reference manual), people will certainly make the wrong assumption about which Model it is and wonder why the model supplied to an exception handler is empty.