AbstractEmbeddedDatabaseConfigurer.shutdown does not close JDBC resources [SPR-13474]

[spring-projects-issues]

Jimmy Praet opened SPR-13474 and commented

AbstractEmbeddedDatabaseConfigurer.shutdown opens a JDBC connection to issue a SHUTDOWN command to the database, but does not close this connection.

It might seem unnecessary at first sight to close this connection, as we are shutting down the database anyway. However, for H2 this unclosed connection is triggering its keepOpenStacktrace logging modus. From that point on, it will generate a stacktrace for each opened connection, which is quite costly.

---

Affects: 3.2.14, 4.1.7, 4.2.1

Referenced from: commits 51a0237, b23c232, aa0f117

Backported to: 4.1.8, 3.2.15

[spring-projects-issues]

Juergen Hoeller commented

Thanks for the report! As of 4.2.2 and 4.1.8, we're explicitly closing that JDBC Connection for the shutdown statement (which should be entirely sufficient and won't create serious side effects).

To be backported to 3.2.15 as well, whenever that one happens.

Juergen