ClasspathXmlApplicationContext cannot be closed twice [SPR-13425]

[spring-projects-issues]

Eric Vigeant opened SPR-13425 and commented

Here is some simple code that will show the pattern:

ClassPathXmlApplicationContext ctx = ...

ctx.refresh(); // This works as expected
ctx.close(); // This closes the context correctly
ctx.refresh(); // This restarts the context properly
ctx.close(); // This does NOT close the context

I traced it down to the "closed" field in AbstractApplicationContext, it is initialized to false, it is set to true when closing, but it is never set again to false after it is restarted. This causes the doClose() method to do nothing.

---

Affects: 4.1.7, 4.2 GA

Issue Links:

• Close processing triggered by shutdown hook isn't thread safe [SPR-13556] #18132 Close processing triggered by shutdown hook isn't thread safe

Referenced from: commits 811de8e, 57125c0

Backported to: 4.1.8

[spring-projects-issues]

Juergen Hoeller commented

close() isn't actually defined for repeated calls on the same ApplicationContext instance, in contrast to refresh() which - on a re-refreshable context - does allow for repeated calls. In a sequence as yours, you'd just call refresh() twice, with a single close() call at the end.

That said, it should be easy enough to allow for repeated closing and refreshing here. There might be subtleties beyond the "closed" field, but even with that in mind, it's worth trying since regular single close() calls will keep working fine... I'm not expecting any regressions there.

Juergen