UriComponents should support URI variables that contain a regex [SPR-13311]

[spring-projects-issues]

nbank opened SPR-13311 and commented

In org.springframework.web.util.UriComponents#NAMES_PATTERN the following Pattern is used: {([^/]+?)}

If you use Path-Variables like myurl/{name:[a-z]{1,5}}/show so accept only 5 lower case letters, then the UriCompents work wrong, because it will expand for name=test to myurl/test}/show which is wrong.

One Workaround is to cleanup the url before with

url.replaceAll("\\{([A-Za-z0-9_-]+?):([^{}]+?\\{[0-9,]+?\\})*([^{}]+)*\\}", "{$1}");

---

Affects: 4.1.7

Issue Links:

• UriTemplate should support regex matching with n times {n} pattern [SPR-13627] #18205 UriTemplate should support regex matching with n times {n} pattern

Referenced from: commits 2e79a30

[spring-projects-issues]

Rossen Stoyanchev commented

I'm guessing you're running into this by using MvcUriComponentsBuilder? We'll probably need to clean up the URI template in MvcUriComponentsBuilder.

[spring-projects-issues]

nbank commented

No I use the UriComponents directly. I have a central URL-class where all URLs are defined as constants. There I have methods to replace the parameters.
See https://github.com/opensource21/fuwesta/blob/32bf0c47949fb07ac4584f7c26aa77566b336b9d/fuwesta-sample/src/main/java/de/ppi/samples/fuwesta/frontend/URL.java#L251 for details.