Support @ResponseStatus with RedirectView [SPR-13197]

[spring-projects-issues]

Christopher Smith opened SPR-13197 and commented

This is a duplicate of #10812, which was closed by allowing a programmatic setting of the response code on the RedirectView object. It would be convenient to be able to set this with @ResponseStatus on the controller method if this is practical.

---

Affects: 4.2 RC2

Issue Links:

• @ResponseStatus annotation is ignored in an @Controller redirect (RedirectView) [SPR-6144] #10812 @ResponseStatus annotation is ignored in an @Controller redirect (RedirectView)
• Make RedirectViews use RESPONSE_STATUS_ATTRIBUTE as a response status if defined [SPR-13208] #17800 Make RedirectViews use RESPONSE_STATUS_ATTRIBUTE as a response status if defined
• Document that @ResponseStatus overrides redirect views [SPR-13439] #18019 Document that @ResponseStatus overrides redirect views

Referenced from: commits spring-attic/spring-framework-issues@6521f15

[spring-projects-issues]

Rossen Stoyanchev commented

I'm pretty sure that @ResponseStatus works with redirects. This is done through a request attribute View.RESPONSE_STATUS_ATTRIBUTE. Does it not work?

[spring-projects-issues]

Christopher Smith commented

I can confirm that it does not work with the RedirectView object as of 4.2 RC2.

[spring-projects-issues]

Rossen Stoyanchev commented

Can you provide a sample controller method of what you're using?

[spring-projects-issues]

Christopher Smith commented

Both of these controller methods produced 302s:

    @RequestMapping("about/benefits")
    @ResponseStatus(HttpStatus.MOVED_PERMANENTLY)
    def aboutBenefitsRedirect() {
        new RedirectView('/about/portfolios')
    }

    @RequestMapping("about/test")
    @ResponseStatus(HttpStatus.MOVED_PERMANENTLY)
    def testRedirect() {
        'redirect:/about/portfolios'
    }

[spring-projects-issues]

Rossen Stoyanchev commented

If you look in RedirectView in the method getHttp11StatusCode it clearly checks the value from @ResponseStatus. However you must ensure that http10Compatible=false (true by default). I've added a repro project that demonstrates this. You configuration may be a little different but this should give you an idea.

[spring-projects-issues]

Christopher Smith commented

Aha. With HTTP/2 now a thing, might it be time to change the default to false?

[spring-projects-issues]

Brian Clozel commented

Good idea Christopher Smith!
We've created #17800 to fix this.