Support HandlerMethod parameter in @MessageExceptionHandler [SPR-13196]

[spring-projects-issues]

Alex opened SPR-13196 and commented

I have a @ControllerAdvice that handles exceptions using @MessageExceptionHandler methods.

One of these methods has this kind of signature:

  @MessageExceptionHandler
  @SendToUser("/queue/errors")
  public StompRpcException handleException(BadParamException e, SimpMessageHeaderAccessor headerAccessor, HandlerMethod handlerMethod) {
...

and when it gets called spring fails with the following error:

2015-07-03 17:40:22.807 ERROR AnnotationMethodMessageHandler ndlerMethodException Error while processing handler method exception

org.springframework.messaging.converter.MessageConversionException: Could not read JSON: No suitable constructor found for type [simple type, class org.springframework.messaging.handler.HandlerMethod]: can not instantiate from JSON object (missing default constructor or creator, or perhaps need to add/enable type information?)
 at [Source: [B@14019705; line: 1, column: 2]; nested exception is com.fasterxml.jackson.databind.JsonMappingException: No suitable constructor found for type [simple type, class org.springframework.messaging.handler.HandlerMethod]: can not instantiate from JSON object (missing default constructor or creator, or perhaps need to add/enable type information?)
 at [Source: [B@14019705; line: 1, column: 2]
        at org.springframework.messaging.converter.MappingJackson2MessageConverter.convertFromInternal(MappingJackson2MessageConverter.java:210)
        at org.springframework.messaging.converter.AbstractMessageConverter.fromMessage(AbstractMessageConverter.java:181)
        at org.springframework.messaging.converter.CompositeMessageConverter.fromMessage(CompositeMessageConverter.java:55)
        at org.springframework.messaging.handler.annotation.support.PayloadArgumentResolver.resolveArgument(PayloadArgumentResolver.java:113)
        at org.springframework.messaging.handler.invocation.HandlerMethodArgumentResolverComposite.resolveArgument(HandlerMethodArgumentResolverComposite.java:77)
        at org.springframework.messaging.handler.invocation.InvocableHandlerMethod.getMethodArgumentValues(InvocableHandlerMethod.java:129)
        at org.springframework.messaging.handler.invocation.InvocableHandlerMethod.invoke(InvocableHandlerMethod.java:102)
        at org.springframework.messaging.handler.invocation.AbstractMethodMessageHandler.processHandlerMethodException(AbstractMethodMessageHandler.java:496)
        at org.springframework.messaging.handler.invocation.AbstractMethodMessageHandler.handleMatch(AbstractMethodMessageHandler.java:478)
        at org.springframework.messaging.simp.annotation.support.SimpAnnotationMethodMessageHandler.handleMatch(SimpAnnotationMethodMessageHandler.java:456)
        at org.springframework.messaging.simp.annotation.support.SimpAnnotationMethodMessageHandler.handleMatch(SimpAnnotationMethodMessageHandler.java:84)
        at org.springframework.messaging.handler.invocation.AbstractMethodMessageHandler.handleMessageInternal(AbstractMethodMessageHandler.java:423)
        at org.springframework.messaging.handler.invocation.AbstractMethodMessageHandler.handleMessage(AbstractMethodMessageHandler.java:361)
        at org.springframework.messaging.support.ExecutorSubscribableChannel$SendTask.run(ExecutorSubscribableChannel.java:135)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)
Caused by: com.fasterxml.jackson.databind.JsonMappingException: No suitable constructor found for type [simple type, class org.springframework.messaging.handler.HandlerMethod]: can not instantiate from JSON object (missing default constructor or creator, or perhaps need to add/enable type information?)
 at [Source: [B@14019705; line: 1, column: 2]
        at com.fasterxml.jackson.databind.JsonMappingException.from(JsonMappingException.java:148)
        at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.deserializeFromObjectUsingNonDefault(BeanDeserializerBase.java:1080)
        at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserializeFromObject(BeanDeserializer.java:295)
        at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserialize(BeanDeserializer.java:142)
        at com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:3564)
        at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:2705)
        at org.springframework.messaging.converter.MappingJackson2MessageConverter.convertFromInternal(MappingJackson2MessageConverter.java:203)
        ... 16 common frames omitted

---

Affects: 4.2 RC2

Issue Links:

• Provide access to the target HandlerMethod from @ExceptionHandler methods [SPR-12605] #17206 Provide access to the target HandlerMethod from @ExceptionHandler methods

Referenced from: commits 9793614

[spring-projects-issues]

Rossen Stoyanchev commented

Recently we added support on the Spring MVC side (#17206). It should be trivial to make the same work on the messaging side as well.

[spring-projects-issues]

Sébastien Deleuze commented

Support added by this commit.

Alex Be aware that HandlerMethod has no default constructor, so it can't be serialized directly by Jackson. You may have to get the fields you need from the HandlerMethod instance, and store them in another POJO used for serialization.

[spring-projects-issues]

Rossen Stoyanchev commented

I'm guessing Jackson kicked in here since nothing else could resolve HandlerMethod.

[spring-projects-issues]

Alex commented

In fact it's a Jackson Exception, but this used to work a few releases ago