@Order annotations not consistently honored within DispatcherServlet and other parts of the framework [SPR-12806]

[spring-projects-issues]

Oliver Drotbohm opened SPR-12806 and commented

DispatcherServlet.initHandlerMappings(…) uses OrderComparator.sort(…) instead of AnnotationAwareOrderComparator.sort(…) which misses out HandlerMappings that use @Order instead of implementing Ordered.

Probably an oversight that stems from the times when @Order didn't even exists. Might be worth grepping the framework sources for other uses of OrderComparator as I think AnnotationAwareOrderComparator should be used everywhere OrderComparator is used nowadays.

---

Affects: 4.0.9, 4.1.5

Issue Links:

• Support @Order on ApplicationListeners [SPR-12410] #17018 Support @Order on ApplicationListeners
• Document common use cases for @Order vs @Priority vs @DependsOn [SPR-16213] #20761 Document common use cases for @Order vs @Priority vs @DependsOn

Referenced from: commits 13659d6

[spring-projects-issues]

Juergen Hoeller commented

It's not really an oversight: For traditional Java strategies such as HandlerMapping, we kept using OrderComparator since it fits with the interface model there. Only for annotation-based components, we started delegating to AnnotationAwareOrderComparator.

That said, for 4.2, we are already considering wider use of AnnotationAwareOrderComparator, see e.g. #17018. I suppose we'll cover this for DispatcherServlet's strategies as well then.

Juergen