Remove synchronization around filteredPropertyDescriptorsCache in case of non-existing entry [SPR-12106]

[spring-projects-issues]

Craig opened SPR-12106 and commented

AbstractAutowireCapableBeanFactory.filterPropertyDescriptorsForDependencyCheck synchronizes on filteredPropertyDescriptorsCache.

filteredPropertyDescriptorsCache is a ConcurrentHashMap, so such synchronization is not necessary.

Removing the lock would improve concurrency.

---

Affects: 4.1 RC2

Issue Links:

• Performance regression for custom autowireBean calls with many properties [SPR-11875] #16494 Performance regression for custom autowireBean calls with many properties
• Unnecessarily conservative locking in registerDependentBean is a bottleneck [SPR-8814] #13456 Unnecessarily conservative locking in registerDependentBean is a bottleneck

Referenced from: commits 8eac870

[spring-projects-issues]

Craig commented

#630

[spring-projects-issues]

Juergen Hoeller commented

That synchronized block was only hit in case of a non-existing entry... But good point, even then it's not strictly necessary since the PropertyDescriptor array doesn't need to be unique. Revised for 4.1 GA now.

Juergen