BeanNameViewResolver should not try to use non-View beans [SPR-12079]

[spring-projects-issues]

Oliver Drotbohm opened SPR-12079 and commented

To resolve a view, BeanNameViewResolver checks for the presence of a bean with the view name and then looks it up using context.getBean(name, View.class).

This throws an exception if the view name is the name of an arbitrary Spring bean by accident, which is not a View. I suggest to look up the bean instance without the type constraint and only return it if it really implements View. Alternatively, the BeanNotOfRequiredTypeException could be caught and handled by returning null.

---

Affects: 3.2.10, 4.0.6, 4.1 RC1

Referenced from: commits 42c090e, 626a5fe, 035a9b9, 92bd240

[spring-projects-issues]

Juergen Hoeller commented

I assume this is only really a problem in a chained view resolution scenario where another resolver is able to resolve that view name later on? The downside in a single resolver scenario is that we'd silently not return a view despite the convention having matched, with no indication that the reason was a type mismatch...

Juergen